Python 3.12 - AttributeError: module 'pathlib' has no attribute '_Flavour'

[briantist]

Python 3.12 is now released, but it does not work due to pathlib changes:

/opt/hostedtoolcache/Python/3.12.0-rc.1/x64/lib/python3.12/site-packages/artifactory.py:426: in
class _ArtifactoryFlavour(pathlib._Flavour):
E AttributeError: module 'pathlib' has no attribute '_Flavour'

I figured I'd add 3.12 into the test matrix on my project which relies on this library, and that's how I found this issue:

• https://github.com/briantist/galactory/actions/runs/5844080610/job/15846784439?pr=80#step:5:40

Not any kind of pressing issue yet.

[allburov]

Thank you for the feedback!
If anyone has idea how to fix this - feel free to create a PR

[brot]

Python 3.12 will add support for subclassing pathlib.PurePath and Path

See also the cpython github issue: python/cpython#31691

[barneygale]

I'm hoping to add a pathlib.PathBase class for Python 3.13. Once it's in the codebase, I'll publish a backport package on PyPI for Python <3.13. dohq-artifactory could subclass PathBase to implement ArtifactoryPath.

CPython issue: python/cpython#110109

[ktdreyer]

@barneygale Thank you for your work in core for this. It will be great to simplify the dohq-artifactory codebase.

Do you suggest any other solution for py312 in the meantime? Should we try subclassing something from py312's pathlib prior to pathlib.PathBase being available?

I'm running Python 3.12 on my laptop (Fedora 39), and I've hacked artifactory.py so that it doesn't crash. I can list directories and download and upload basic files. My changes are in my py312 branch, but I'm not sure they're acceptable for a PR here.

[barneygale]

I'd recommend that you wait if you can - I'm expecting to publish a PyPI package with the base classes some time this month.

[barneygale]

Preview: https://github.com/python/cpython/blob/33f9af159adce62008934a6d304511401d650a8d/Lib/pathlib/_abc.py#L535

[barneygale]

Git project: https://github.com/barneygale/pathlib_abc

Currently it only supports Python 3.11+, but I should have it working for 3.8+ within a couple of weeks, at which point I'll publish a PyPI package.

[barneygale]

First PyPI release: https://pypi.org/project/pathlib-abc/0.1.0/

[FHTMitchell]

I'm seeing the same issue in py3.11 now

[dkmiller]

Hey everyone - any progress here?

[zhan9san]

Hey guys,

Thanks for reporting this issue. I'd like to work on it.

[barneygale]

IMO the best way to fix this is to add a dependency on pathlib-abc, and make ArtifactoryPath inherit from PathBase.

@zhan9san is that what you're pursuing? If not I might have a crack at it.

[lukezhangtyler]

I hope this will be remediated soon.

[okainov]

@zhan9san @beliaev-maksim hi folks, any update on this issue? Given Python 3.12 is fully released and supported, it would be very appreciated that Artifactory library supports it, it's the only item blocking our migration to 3.12 now...

[allburov]

We are looking for a volunteer!

[andrewsiemer]

+1 this is blocking migrating to python 3.12

[hacklint]

Any hope of this being resolved before release of python 3.13?

[barneygale]

FWIW I've started a new pathlib-artifactory package building on the semi-official pathlib-abc package. It doesn't rely on hacking into the pathlib internals (unlike dohq-artifactory) so it should be on surer footing. But it's missing tons of features and it's certainly not a drop-in replacement for dohq-artifactory yet. Issues and PRs very welcome.

[mshafer-NI]

@allburov, @barneygale, I took a swing at using the pathlib-abc, but it's erroring on

    from artifactory import ArtifactoryPath
.tox/py39/lib/python3.9/site-packages/artifactory.py:1490: in <module>
    class ArtifactoryPath(pathlib.Path, PureArtifactoryPath):
/pyenv/versions/3.9.18/lib/python3.9/abc.py:106: in __new__
    cls = super().__new__(mcls, name, bases, namespace, **kwargs)
E   TypeError: multiple bases have instance lay-out conflict

You can see my progress here: mshafer-NI#1

[LeiYangGH]

any walkaround?

[seltsa]

Any updates for Fedora39 ? Hit the same issue

[LeiYangGH]

FWIW I've started a new pathlib-artifactory package building on the semi-official pathlib-abc package. It doesn't rely on hacking into the pathlib internals (unlike dohq-artifactory) so it should be on surer footing. But it's missing tons of features and it's certainly not a drop-in replacement for dohq-artifactory yet. Issues and PRs very welcome.

thanks and could you add a little document on the readme, for example, why create the project, are the usage compatible with devopshq artifactory?

[FrogWithASock]

Any updates? Is this project dead? There was no commit to main for 7 months now

[allburov]

Is this project dead?

Not dead, but yeah, no active maintainer here :(
We're happy to review any PR for the issue and any help! 🙏

I don't work with artifactory anymore, so can not even test it :(

[oscarm3l1n]

@barneygale Thank you for your work in core for this. It will be great to simplify the dohq-artifactory codebase.

Do you suggest any other solution for py312 in the meantime? Should we try subclassing something from py312's pathlib prior to pathlib.PathBase being available?

I'm running Python 3.12 on my laptop (Fedora 39), and I've hacked artifactory.py so that it doesn't crash. I can list directories and download and upload basic files. My changes are in my py312 branch, but I'm not sure they're acceptable for a PR here.

Tested this locally, works like a charm!

[oscarm3l1n]

@barneygale Thank you for your work in core for this. It will be great to simplify the dohq-artifactory codebase.

Do you suggest any other solution for py312 in the meantime? Should we try subclassing something from py312's pathlib prior to pathlib.PathBase being available?

I'm running Python 3.12 on my laptop (Fedora 39), and I've hacked artifactory.py so that it doesn't crash. I can list directories and download and upload basic files. My changes are in my py312 branch, but I'm not sure they're acceptable for a PR here.

@ktdreyer
Since it's been almost a year. Have you worked around this issue somehow? (sounded on your implementation that it was more of a hack)

[RoccoMatano]

I use a little application that depends on artifactory and I want to run it with current python versions (i.e. 3.13). I don't know anything about the internals of artifactory, but I managed to patch it in such a way, that it fullfills my needs. I have no idea whether this works for all use cases.
For what it's worth, here's the diff:

--- C:\prj\progs\py313\Lib\site-packages\artifactory.0.10.1.py	2024-10-08 08:10:50.000000000 +0200
+++ C:\prj\progs\py313\Lib\site-packages\artifactory.py	2024-10-08 08:16:13.000000000 +0200
@@ -419,13 +419,13 @@
         quoted_path = requests.utils.quote(url.partition(parsed_url.host)[2])
         quoted_url = f"{parsed_url.scheme}://{parsed_url.host}{quoted_path}"
 
     return quoted_url
 
 
-class _ArtifactoryFlavour(pathlib._Flavour):
+class _ArtifactoryFlavour:
     """
     Implements Artifactory-specific pure path manipulations.
     I.e. what is 'drive', 'root' and 'path' and how to split full path into
     components.
     See 'pathlib' documentation for explanation how those are used.
 
@@ -437,13 +437,12 @@
     path: relative artifact path within the repository
     """
 
     sep = "/"
     altsep = "/"
     has_drv = True
-    pathmod = pathlib.posixpath
     is_supported = True
 
     def _get_base_url(self, url):
         return get_global_base_url(url)
 
     def compile_pattern(self, pattern):
@@ -1498,25 +1497,33 @@
     """
 
     if sys.version_info.major == 3 and sys.version_info.minor >= 10:
         # see changes in pathlib.Path, slots are no more applied
         # https://github.com/python/cpython/blob/ce121fd8755d4db9511ce4aab39d0577165e118e/Lib/pathlib.py#L952
         _accessor = _artifactory_accessor
+        parser = _ArtifactoryFlavour()
     else:
         # in 3.9 and below Pathlib limits what members can be present in 'Path' class
         __slots__ = ("auth", "verify", "cert", "session", "timeout")
+
+    def __init__(self, *args, **kwargs):
+        # supplying keyword arguments to pathlib.PurePath is deprecated
+        return super().__init__(*args)
 
     def __new__(cls, *args, **kwargs):
         """
         pathlib.Path overrides __new__ in order to create objects
         of different classes based on platform. This magic prevents
         us from adding an 'auth' argument to the constructor.
         So we have to first construct ArtifactoryPath by Pathlib and
         only then add auth information.
         """
         obj = pathlib.Path.__new__(cls, *args, **kwargs)
+        if sys.version_info.major == 3 and sys.version_info.minor >= 12:
+            # supplying keyword arguments to pathlib.PurePath is deprecated
+            obj.__init__(*args)
 
         cfg_entry = get_global_config_entry(obj.drive)
 
         # Auth section
         apikey = kwargs.get("apikey")
         token = kwargs.get("token")

[hacklint]

I use a little application that depends on artifactory and I want to run it with current python versions (i.e. 3.13). I don't know anything about the internals of artifactory, but I managed to patch it in such a way, that it fullfills my needs. I have no idea whether this works for all use cases. For what it's worth, here's the diff:

--- C:\prj\progs\py313\Lib\site-packages\artifactory.0.10.1.py	2024-10-08 08:10:50.000000000 +0200
+++ C:\prj\progs\py313\Lib\site-packages\artifactory.py	2024-10-08 08:16:13.000000000 +0200
@@ -419,13 +419,13 @@
         quoted_path = requests.utils.quote(url.partition(parsed_url.host)[2])
         quoted_url = f"{parsed_url.scheme}://{parsed_url.host}{quoted_path}"
 
     return quoted_url
 
 
-class _ArtifactoryFlavour(pathlib._Flavour):
+class _ArtifactoryFlavour:
     """
     Implements Artifactory-specific pure path manipulations.
     I.e. what is 'drive', 'root' and 'path' and how to split full path into
     components.
     See 'pathlib' documentation for explanation how those are used.
 
@@ -437,13 +437,12 @@
     path: relative artifact path within the repository
     """
 
     sep = "/"
     altsep = "/"
     has_drv = True
-    pathmod = pathlib.posixpath
     is_supported = True
 
     def _get_base_url(self, url):
         return get_global_base_url(url)
 
     def compile_pattern(self, pattern):
@@ -1498,25 +1497,33 @@
     """
 
     if sys.version_info.major == 3 and sys.version_info.minor >= 10:
         # see changes in pathlib.Path, slots are no more applied
         # https://github.com/python/cpython/blob/ce121fd8755d4db9511ce4aab39d0577165e118e/Lib/pathlib.py#L952
         _accessor = _artifactory_accessor
+        parser = _ArtifactoryFlavour()
     else:
         # in 3.9 and below Pathlib limits what members can be present in 'Path' class
         __slots__ = ("auth", "verify", "cert", "session", "timeout")
+
+    def __init__(self, *args, **kwargs):
+        # supplying keyword arguments to pathlib.PurePath is deprecated
+        return super().__init__(*args)
 
     def __new__(cls, *args, **kwargs):
         """
         pathlib.Path overrides __new__ in order to create objects
         of different classes based on platform. This magic prevents
         us from adding an 'auth' argument to the constructor.
         So we have to first construct ArtifactoryPath by Pathlib and
         only then add auth information.
         """
         obj = pathlib.Path.__new__(cls, *args, **kwargs)
+        if sys.version_info.major == 3 and sys.version_info.minor >= 12:
+            # supplying keyword arguments to pathlib.PurePath is deprecated
+            obj.__init__(*args)
 
         cfg_entry = get_global_config_entry(obj.drive)
 
         # Auth section
         apikey = kwargs.get("apikey")
         token = kwargs.get("token")

Tried this locally, worked fine for what I tested (read-only from Artifactory, no writes tested)

[LeiYangGH]

I use a little application that depends on artifactory and I want to run it with current python versions (i.e. 3.13). I don't know anything about the internals of artifactory, but I managed to patch it in such a way, that it fullfills my needs. I have no idea whether this works for all use cases. For what it's worth, here's the diff:

--- C:\prj\progs\py313\Lib\site-packages\artifactory.0.10.1.py	2024-10-08 08:10:50.000000000 +0200
+++ C:\prj\progs\py313\Lib\site-packages\artifactory.py	2024-10-08 08:16:13.000000000 +0200
@@ -419,13 +419,13 @@
         quoted_path = requests.utils.quote(url.partition(parsed_url.host)[2])
         quoted_url = f"{parsed_url.scheme}://{parsed_url.host}{quoted_path}"
 
     return quoted_url
 
 
-class _ArtifactoryFlavour(pathlib._Flavour):
+class _ArtifactoryFlavour:
     """
     Implements Artifactory-specific pure path manipulations.
     I.e. what is 'drive', 'root' and 'path' and how to split full path into
     components.
     See 'pathlib' documentation for explanation how those are used.
 
@@ -437,13 +437,12 @@
     path: relative artifact path within the repository
     """
 
     sep = "/"
     altsep = "/"
     has_drv = True
-    pathmod = pathlib.posixpath
     is_supported = True
 
     def _get_base_url(self, url):
         return get_global_base_url(url)
 
     def compile_pattern(self, pattern):
@@ -1498,25 +1497,33 @@
     """
 
     if sys.version_info.major == 3 and sys.version_info.minor >= 10:
         # see changes in pathlib.Path, slots are no more applied
         # https://github.com/python/cpython/blob/ce121fd8755d4db9511ce4aab39d0577165e118e/Lib/pathlib.py#L952
         _accessor = _artifactory_accessor
+        parser = _ArtifactoryFlavour()
     else:
         # in 3.9 and below Pathlib limits what members can be present in 'Path' class
         __slots__ = ("auth", "verify", "cert", "session", "timeout")
+
+    def __init__(self, *args, **kwargs):
+        # supplying keyword arguments to pathlib.PurePath is deprecated
+        return super().__init__(*args)
 
     def __new__(cls, *args, **kwargs):
         """
         pathlib.Path overrides __new__ in order to create objects
         of different classes based on platform. This magic prevents
         us from adding an 'auth' argument to the constructor.
         So we have to first construct ArtifactoryPath by Pathlib and
         only then add auth information.
         """
         obj = pathlib.Path.__new__(cls, *args, **kwargs)
+        if sys.version_info.major == 3 and sys.version_info.minor >= 12:
+            # supplying keyword arguments to pathlib.PurePath is deprecated
+            obj.__init__(*args)
 
         cfg_entry = get_global_config_entry(obj.drive)
 
         # Auth section
         apikey = kwargs.get("apikey")
         token = kwargs.get("token")

Tried this locally, worked fine for what I tested (read-only from Artifactory, no writes tested)

how to apply this patch after installing the official module?
it would be great if we can copy the patch to our project source folder which then 'monkey patch' the installed official module. is it possible?

[allburov]

patching is not the way to go, we should add it as built-in fix (if it works for all cases)

Let's not discuss patching here, I'll mark the comment as Off Topic in the future

[okainov]

For what it's worth, here's the diff:

@RoccoMatano FYI I've created PR based on your patch #458

[Gris87]

Hi, any progress with this issue?