Fix latercera portada #625
+55
−46
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ | |
| "singleQuote": true, | ||
| "semi": false, | ||
| "printWidth": 120 | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,13 +87,11 @@ const diarios = { | |
| noSlashes: false | ||
| }, | ||
| tercera: { | ||
| url: 'https://kiosco.latercera.com/latest-issue-cover-image?collection=lt_diario_la_tercera_6_30&nocache=#DATE#', | ||
| noSlashes: true | ||
| }, | ||
| cuarta: { | ||
| url: 'https://kiosco.lacuarta.com/latest-issue-cover-image?collection=lc_diario_la_cuarta&nocache=#DATE#', | ||
| noSlashes: true | ||
| }, | ||
| estrellaarica: { | ||
|
|
@@ -301,46 +299,48 @@ const getPortada = (res, diario) => { | |
| const fecha = moment().subtract(daysPast, 'days') | ||
| testUrl = diario.url.replace('#DATE#', formatDate(fecha, diario.noSlashes)) | ||
| return new Promise((resolve, reject) => { | ||
| res.http(testUrl).timeout(2000).get()((err, response, body) => { | ||
|
There was a problem hiding this comment. No soy muy fan del estilo, pero la indentación debería ser igual al archivo original There was a problem hiding this comment. Entonces prettier no está configurado en el proyecto, no? @gmq |
||
| if (err) return reject(err) | ||
| switch (response.statusCode) { | ||
| case 404: | ||
| daysPast++ | ||
| resolve(testUrl) | ||
| break | ||
| case 200: | ||
| ready = false | ||
| if (testUrl === endpointHxh) { | ||
| try { | ||
| var jsonHxh = JSON.parse(body) | ||
| testUrl = jsonHxh[0].esPortadaFalsa || diario.forcePortada ? jsonHxh[3].img : jsonHxh[0].img | ||
| const dateFromHxh = testUrl && testUrl.split('/')[4] | ||
| dateFromHxh && sendPortadaDate(res, moment(dateFromHxh, 'DDMMYY').toDate()) | ||
| resolve(testUrl) | ||
| } catch (err) { | ||
| reject(err) | ||
| } | ||
| } else { | ||
| sendPortadaDate(res, fecha) | ||
| resolve(testUrl) | ||
| } | ||
| break | ||
| case 302: | ||
PotterSys marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ready = false | ||
| sendPortadaDate(res, fecha) | ||
| resolve(testUrl) | ||
|
There was a problem hiding this comment. En este caso, debería devolver el header |
||
| break | ||
| default: | ||
| resolve() | ||
| break | ||
| } | ||
| }) | ||
| }) | ||
| } | ||
| } | ||
| ) | ||
| } | ||
|
|
||
| module.exports = (robot) => { | ||
| robot.respond(/portada (.*)/i, (res) => { | ||
| const nombre = res.match[1] | ||
| .toLowerCase() | ||
| .replace(/^(las |la |el |le |the |o |il )/, '') | ||
|
|
@@ -361,11 +361,11 @@ module.exports = robot => { | |
| res.send(listaPortadas()) | ||
| } else if (nombre in diarios) { | ||
| getPortada(res, diarios[nombre]) | ||
| .then((result) => { | ||
| if (!result) return res.send('No hay portada disponible') | ||
| res.send(result) | ||
| }) | ||
| .catch((err) => { | ||
| robot.emit('error', err, res, 'portadas') | ||
| }) | ||
| } else { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Un version bump debería estar en un PR aparte
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De hecho este cambio completo debería ser un PR aparte, no es de latercera este cambio?