Ratings CRUD #516
Merged
Ratings CRUD #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
KavikaPalletenne
requested changes
Oct 7, 2024
|
Write API docs in yaml file. |
KavikaPalletenne
requested changes
Nov 11, 2024
| FROM organisation_members om | ||
| JOIN campaigns c ON om.organisation_id = c.organisation_id | ||
| JOIN applications a ON a.campaign_id = c.id | ||
| JOIN application_ratings ar ON a.campaign_id = c.id |
There was a problem hiding this comment.
Suggested change
| JOIN application_ratings ar ON a.campaign_id = c.id |
| /// Any member of the organisation that owns the campaign is an application | ||
| /// viewer, because all members are either directors or execs (TODO: might be | ||
| /// changed in the future). | ||
| pub async fn assert_user_is_application_reviewer_admin_given_application_id( |
There was a problem hiding this comment.
This whole thing might not be needed yet because if a person is an organisation member, they are also an application reviewer, so this authZ check should be covered by the function assert_user_is_organisation_member below
There was a problem hiding this comment.
But we can keep it, and update the internal logic later once we add Organisation roles
KavikaPalletenne
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.