Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upstream sync issues on windows #374

Closed
LukasGentele opened this issue Nov 8, 2018 · 2 comments · Fixed by #397
Closed

Fix upstream sync issues on windows #374

LukasGentele opened this issue Nov 8, 2018 · 2 comments · Fixed by #397
Assignees
Labels
area/sync Issues related to the real-time code synchronization system/windows Issues related to using DevSpace CLI on Windows

Comments

@LukasGentele
Copy link
Contributor

What happened?
Running devspace up starts the initial sync process. If many files are synced down and changed locally, it may happen that the file watcher process on windows dies without any errors which leads to a non-functional upstream sync.

What did you expect to happen instead?
File watcher should not die when changing many files locally or they should be restarted automatically to ensure that upstream file syncing always works.

How can we reproduce the bug? (as minimally and precisely as possible)

  1. Checkout a nodejs project with a large number of dependencies on windows
  2. run devspace up
  3. change a file locally and check if it has been synchronized to the remote container

Local Environment:

  • Operating System: windows
  • Deployment method: helm

Kubernetes Cluster:

  • Cloud Provider: DevSpace Cloud Enterprise

Anything else we need to know?
This might also affect the quickstart guide making it even more important.

/kind bug

@LukasGentele LukasGentele added priority/critical area/sync Issues related to the real-time code synchronization system/windows Issues related to using DevSpace CLI on Windows labels Nov 8, 2018
@FabianKramm
Copy link
Collaborator

FabianKramm commented Nov 9, 2018

I tracked down the issue to the github.com/rjeczalik/notify library (in file watcher_readdcw.go). The problem is that the windows API syscall syscall.GetQueuedCompletionStatus during watching does not write any bytes into the overlapped struct (not sure why though), which leads to the skip of the syscall syscall.ReadDirectoryChanges, which in return leads to an endless waiting in the next loop run of syscall.GetQueuedCompletionStatus. I'll implement a potential fix and test some more and then open a pull request to fix that issue in the library.

@FabianKramm
Copy link
Collaborator

I created a pull request in the library that was merged yesterday which should fix the issue, so we only have to update our dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sync Issues related to the real-time code synchronization system/windows Issues related to using DevSpace CLI on Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants