fix: remove the use of the --short flag in kubectl version #2696
Conversation
✅ Deploy Preview for devspace-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
.github/workflows/e2e-tests.yaml
Outdated
| uses: azure/setup-kubectl@v3 | ||
| with: | ||
| version: ${{ matrix.kubectl_version }} | ||
|
|
||
| # Creates KinD with using k8s versions from the matrix above | ||
| - name: Set up kind with K8s version v1.22.4 | ||
| uses: engineerd/setup-kind@v0.5.0 | ||
| with: | ||
| version: "v0.11.1" | ||
| image: kindest/node:v1.22.4 |
There was a problem hiding this comment.
We probably should also adjust the node image version to the kubectl version, in which case we should rename the matrix variable name to kubernetes version or just kubernetes.
| image: kindest/node:v1.22.4 | |
| image: kindest/node:${{ matrix.kubectl_version }} |
There was a problem hiding this comment.
This gets trickier, since KinD doesn't distribute all versions (v1.27.4 is not available for example), and also not all KinD images are compatible with newer versions. I'll give it a shot, but we may need to manage the versions separately.
|
Thanks for the PR @lizardruss . We were wondering when this might be merged + released in a stable version? |
Fixes ENG-1890 Signed-off-by: Russell Centanni <russell.centanni@gmail.com> Co-authored-by: JoshInLondon <joshua.summers@boardintelligence.com> Co-authored-by: Martin Chatterton <martin.paul.chatterton@gmail.com> Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
Fixes ENG-1890 Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
|
@JoshInLisbon We will aim for a release next week. |
|
Hi @lizardruss, would it be possible to provide an update on when there might be a new stable release? At the moment I am using a locally produced binary of Devspace. I would like to be able to use a stable release again. This also impacts adoption among other developers. |
|
@JoshInLisbon DevSpace v6.3.3 has been released and contains this fix. |
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2694
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ran the kubectl version command with the flag --short. This is depreciated in v1.28 of kubectl, so DevSpace would no longer deploy K8s manifests. We use the --output=json flag to standardise the kubectl version result across versions.
What else do we need to know?
Fixes ENG-1890