New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add services (closes #345) #353

Merged

FabianKramm merged 1 commit into master from issue-345

Nov 5, 2018

Contributor

LukasGentele commented Nov 4, 2018

What issue type does this pull request address? (keep at least one, remove the others)
/kind feature

What is this pull request for? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #345

Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
yes, it:

adds devSpace.services to config
adds command devspace list service
removes devSpace.sync[].resourceType (because this is always pod)
devspace add package X will add X as service (maybe a flag could be implemented to control this behavior)

Does this pull request add new dependencies?
no

What else do we need to know?
additional todos could be to implement the convenience commands:

devspace add service
devspace remove service


          add services (closes #345)

c9ef4dc

LukasGentele requested a review from FabianKramm

November 4, 2018 23:50

FabianKramm merged commit d8e184a into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet