fix: ci error

Signed-off-by: Bird <aflybird0@gmail.com>
devstream-io · Oct 11, 2022 · 06eca74 · 06eca74
1 parent 6ffd660
commit 06eca74
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/pkg/util/downloader/downloader.go b/pkg/util/downloader/downloader.go
@@ -85,13 +85,11 @@ func (d *Downloader) Download(url, filename, targetDir string) (size int64, err
 	}
 
 	if err != nil {
-		log.Error(err)
 		return 0, err
 	}
 
 	// rename, tmp file to real file
 	if err = os.Rename(pluginTmpLocation, pluginLocation); err != nil {
-		log.Error(err)
 		return 0, err
 	}
 	return size, nil

diff --git a/pkg/util/scm/github/download_test.go b/pkg/util/scm/github/download_test.go
@@ -158,7 +158,7 @@ var _ = Describe("DownloadAsset", func() {
 			Expect(ghClient).NotTo(Equal(nil))
 			err = ghClient.DownloadAsset(tagName, assetName, ".")
 			Expect(err).To(HaveOccurred())
-			Expect(err.Error()).To(ContainSubstring(fmt.Sprintf("failed to get the filename from url: %s", downloadUrl)))
+			Expect(err.Error()).To(ContainSubstring("filename must not be dir"))
 		})
 	})