Skip to content

Commit

Permalink
chore: update according iyear's review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
  • Loading branch information
daniel-hutao committed Oct 11, 2022
1 parent 1f6a7d0 commit 625c6df
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions internal/pkg/plugin/devlakeconfig/devlakeconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ func ApplyConfig(options plugininstaller.RawOptions) error {
}

func createConnections(host string, pluginName string, connections []Connection) error {
for _, c := range connections {
log.Infof("(%s)", c.Name)
for i, c := range connections {
log.Infof("Connection %s: %s", i, c.Name)
configs, err := json.Marshal(c)
if err != nil {
return err
Expand All @@ -74,7 +74,7 @@ func createConnections(host string, pluginName string, connections []Connection)
}

func createConnection(url string, bodyWithJson []byte) error {
req, err := http.NewRequest("POST", url, bytes.NewBuffer(bodyWithJson))
req, err := http.NewRequest(http.MethodPost, url, bytes.NewBuffer(bodyWithJson))
if err != nil {
return err
}
Expand Down

0 comments on commit 625c6df

Please sign in to comment.