-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create namespace auto check if exist #1016
feat: create namespace auto check if exist #1016
Conversation
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove the create_namespace
param and create ns when the ns is not exists.
I agree with Daniel here; the param |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
ad790b1
to
e9773af
Compare
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
Related Issues
close #1014