Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create namespace auto check if exist #1016

Merged

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Aug 19, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • plugin installed by helm support default namespace, with name pluginname
  • update doc for override default value
  • namepsace support upsert

Related Issues

close #1014

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber requested review from IronCore864 and a team as code owners August 19, 2022 04:44
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the create_namespace param and create ns when the ns is not exists.

@IronCore864
Copy link
Member

I think we can remove the create_namespace param and create ns when the ns is not exists.

I agree with Daniel here; the param create_namespace seems redundant now.

Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber force-pushed the feat-plugin-default-namespace branch from ad790b1 to e9773af Compare August 22, 2022 05:31
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@daniel-hutao daniel-hutao merged commit b68cc76 into devstream-io:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: plugin installed by helm support create_namespace
4 participants