Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support automatically detect binary filenames on dtm upgrade #1133

Merged
merged 3 commits into from
Sep 29, 2022
Merged

feat: Support automatically detect binary filenames on dtm upgrade #1133

merged 3 commits into from
Sep 29, 2022

Conversation

CrazyCollin
Copy link
Contributor

@CrazyCollin CrazyCollin commented Sep 27, 2022 •
edited
Loading

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Related to #1110 ,change some code to support get binary file name when execute upgrade command.

Related Issues

#1110

New Behavior (screenshots if needed)

no

@CrazyCollin CrazyCollin requested a review from a team as a code owner September 27, 2022 14:32
@CrazyCollin
feat:Support automatically detect binary filenames on dtm upgrade
04f8558 
Signed-off-by: CrazyCollin <lazycollinl@gmail.com>
@CrazyCollin
Copy link
Contributor Author

hi, @daniel-hutao ,please take a look ,and I 'm really looking forward to your advice.

@CrazyCollin CrazyCollin changed the title feat:Support automatically detect binary filenames on dtm upgrade feat: Support automatically detect binary filenames on dtm upgrade Sep 29, 2022
@CrazyCollin
fix: use debugf
ff34474 
Signed-off-by: CrazyCollin <lazycollinl@gmail.com>
iyear
iyear approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👏

daniel-hutao
daniel-hutao requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CrazyCollin, thank you for the contribution! You did a good job with this feature! Everything is great here except for a small variable name that could be optimized. I've left a comment below.

internal/pkg/upgrade/upgrade.go Outdated Show resolved Hide resolved
@CrazyCollin
refactor: Rename binFileDir to binFilePath
87b6a15 
Signed-off-by: CrazyCollin <lazycollinl@gmail.com>
@CrazyCollin CrazyCollin requested review from daniel-hutao and removed request for steinliber and IronCore864 September 29, 2022 15:18
daniel-hutao
daniel-hutao approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@daniel-hutao daniel-hutao merged commit e07a621 into devstream-io:main Sep 29, 2022
@daniel-hutao
Copy link
Member

Hi @CrazyCollin, thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!
Here are a few useful things for you to continue your open-source journey:

Last but not least, connect me on WeChat please, I have a gift and a "Contributor Credit" for you!

@CrazyCollin
Copy link
Contributor Author

Hi @CrazyCollin, thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack! Here are a few useful things for you to continue your open-source journey:

Last but not least, connect me on WeChat please, I have a gift and a "Contributor Credit" for you!

Thank you! I have already joined the slack channel.

@aFlyBird0 aFlyBird0 mentioned this pull request Oct 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyear iyear iyear approved these changes

@daniel-hutao daniel-hutao daniel-hutao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CrazyCollin @daniel-hutao @iyear