feat: add process bar during dtm upgrade
#1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A kind reminder that you haven't signed off on your commit(s) yet. Check out our official doc to learn how to do this. |
Signed-off-by: 0zyt <zyt0@duck.com>
I already signed it |
steinliber
reviewed
Oct 7, 2022
There was a problem hiding this comment.
Hi @0zyt, thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!
Here are a few useful things for you to continue your open-source journey:
- If you are searching for something else to work on, please see "find an issue".
- Check out our new contributor guide and the "Developer Guide".
- Read our blog; they are on Medium, too.
I think you did a great job with this feature! Everything is great here except for a small function name need to change.
Signed-off-by: 0zyt <zyt0@duck.com>
|
Thank you for your contributions again! 🙌 Just don't forget to remove "todo" if you finish a feature next time. @0zyt
P.S. A small markdown syntax detail:
* [x] task done |
steinliber
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 0zyt zyt0@duck.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
Added a progress bar to the
dtm upgradeRelated Issues
#1146
New Behavior (screenshots if needed)