Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more ut in plugininstaller #1158

Merged

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Oct 9, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • add UT for plugininstaller
  • refactor k8s state func

Related Issues

close #1154

@steinliber steinliber requested a review from a team as a code owner October 9, 2022 10:03
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber force-pushed the feat-add-ut-for-plugininstaller branch from 4991edc to cd7894f Compare October 9, 2022 10:13
@steinliber steinliber requested a review from a team October 10, 2022 01:45
@daniel-hutao daniel-hutao merged commit ae36aea into devstream-io:main Oct 10, 2022
@daniel-hutao daniel-hutao deleted the feat-add-ut-for-plugininstaller branch October 10, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: Add more UT for internal/pkg/plugininstaller module
3 participants