feat: add devlake-config update method #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warren830
force-pushed
the
feat-devlake-config-update
branch
from
d3ddcac to
e1bb649
Compare
daniel-hutao
requested changes
Oct 17, 2022
There was a problem hiding this comment.
@warren830 Thanks for your contributions! I've left some comments here.
IronCore864
requested changes
Oct 17, 2022
|
@warren830 Please take a look at this pr: #1181 I refactored the State/Resource in that pr. |
warren830
force-pushed
the
feat-devlake-config-update
branch
from
e1bb649 to
bc7fa80
Compare
Signed-off-by: Yingchu Chen <yingchu.chen@merico.dev>
warren830
force-pushed
the
feat-devlake-config-update
branch
2 times, most recently
from
bea3cb2 to
a6d3fef
Compare
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
daniel-hutao
force-pushed
the
feat-devlake-config-update
branch
from
a6d3fef to
76e7569
Compare
warren830
force-pushed
the
feat-devlake-config-update
branch
from
76e7569 to
0716a34
Compare
daniel-hutao
approved these changes
Oct 19, 2022
daniel-hutao
force-pushed
the
feat-devlake-config-update
branch
from
0716a34 to
76e7569
Compare
daniel-hutao
approved these changes
Oct 19, 2022
IronCore864
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yingchu Chen yingchu.chen@merico.dev
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
as we can see, when we changed the config, devlake processed requests from stream as expected