-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add a New Plugin helm-installer
#1196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
daniel-hutao
force-pushed
the
feat-helm
branch
4 times, most recently
from
October 26, 2022 06:51
ae4a326
to
218069a
Compare
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
daniel-hutao
force-pushed
the
feat-helm
branch
from
October 26, 2022 06:53
218069a
to
afb07c5
Compare
Please ignore the linkchecker error. I'll fix it in the next document pr. |
aFlyBird0
reviewed
Oct 26, 2022
steinliber
reviewed
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
aFlyBird0
approved these changes
Oct 26, 2022
steinliber
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
I'll transfer the left plugins in the next pr.
Related Issues
#1194
New Behavior (screenshots if needed)
./dtm apply -f config-helm-installer.yaml -y
TODO