Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set fake k8s client before calling k8s.NewClient() to test #1200

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

aFlyBird0
Copy link
Member

@aFlyBird0 aFlyBird0 commented Oct 27, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • add a new func to test functions which use k8s.NewClient() easily
  • fix broken links

Related Issues

New Behavior (screenshots if needed)

@aFlyBird0 aFlyBird0 requested review from IronCore864 and a team as code owners October 27, 2022 03:40
@aFlyBird0 aFlyBird0 force-pushed the feat-fake-k8s-client branch 3 times, most recently from 96d25cb to 02aee19 Compare October 27, 2022 04:47
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/best-practices/gitops.md Outdated Show resolved Hide resolved
docs/best-practices/gitops.zh.md Outdated Show resolved Hide resolved
docs/plugins/argocdapp.md Outdated Show resolved Hide resolved
Signed-off-by: Bird <aflybird0@gmail.com>
@aFlyBird0 aFlyBird0 force-pushed the feat-fake-k8s-client branch from 02aee19 to cac0db9 Compare October 27, 2022 06:27
@daniel-hutao daniel-hutao merged commit 3cb7bd8 into devstream-io:main Oct 27, 2022
@aFlyBird0 aFlyBird0 deleted the feat-fake-k8s-client branch November 25, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants