Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: configmanager support [[]] format #1240

Merged
merged 2 commits into from
Nov 21, 2022
Merged

refactor: configmanager support [[]] format #1240

merged 2 commits into from
Nov 21, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Nov 18, 2022 •
edited
Loading

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • configmanager support [[]] format of variable
  • use yamlPath to get yaml content
  • add more ut for configmanager

Related Issues

#1239

@steinliber steinliber requested review from IronCore864 and a team as code owners November 18, 2022 11:49
@steinliber steinliber force-pushed the feat-app-config branch 6 times, most recently from 4028ab3 to 48ffa39 Compare November 20, 2022 10:31
@steinliber
refactor: configmanager support [[]] format
36c6297 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
IronCore864
IronCore864 requested changes Nov 21, 2022
View reviewed changes
internal/pkg/configmanager/app.go Outdated Show resolved Hide resolved
internal/pkg/configmanager/app.go Outdated Show resolved Hide resolved
internal/pkg/configmanager/app.go Show resolved Hide resolved
internal/pkg/configmanager/app.go Outdated Show resolved Hide resolved
internal/pkg/configmanager/config.go Outdated Show resolved Hide resolved
pkg/util/file/file.go Outdated Show resolved Hide resolved
pkg/util/mapz/map.go Outdated Show resolved Hide resolved
@steinliber
fix: change func name
61c9bf1 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@IronCore864 IronCore864 merged commit a50e5b6 into devstream-io:main Nov 21, 2022
@IronCore864 IronCore864 deleted the feat-app-config branch November 21, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronCore864 IronCore864 IronCore864 approved these changes

@daniel-hutao daniel-hutao daniel-hutao approved these changes

Assignees

@daniel-hutao daniel-hutao

@IronCore864 IronCore864

@aFlyBird0 aFlyBird0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steinliber @daniel-hutao @IronCore864 @aFlyBird0