Feat: Remove pluginDir Item in Config File #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-hutao
force-pushed
the
config-ht
branch
from
4bd469d to
dce4a72
Compare
IronCore864
approved these changes
Nov 24, 2022
aFlyBird0
approved these changes
Nov 24, 2022
steinliber
approved these changes
Nov 24, 2022
daniel-hutao
force-pushed
the
config-ht
branch
from
ebe4836 to
d3d4554
Compare
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
daniel-hutao
force-pushed
the
config-ht
branch
from
d3d4554 to
0792516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
To further simplify the config file, we decided to use the default plugin directory "~/.devstream/plugins".
Custom plugin directory is no longer supported in the config file. If you do have a need to customize the plugin directory, you can still do so by using the
-dflag. As for why we keep-d, on the one hand, the implementation of-dis very lightweight, almost one line of code, and this one line of code brings more flexibility and seems to be a good gain.Related Issues
#1251
New Behavior (screenshots if needed)
Custom plugin directory is no longer supported in the config file.