Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use aws s3 to download dtm core #1301

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

aFlyBird0
Copy link
Member

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Overview

  1. put dtm-core and download.sh into s3
  2. use CI to achieve automatic

Detail

User View

just execute sh -c "$(curl -fsSL https://download.devstream.io/download.sh)"

Developer View

  1. Upload download.sh to s3 automatically once this script is updated
  2. Upload dtm-core to s3 automatically in every release
  3. Create a leatest_version file to record the latest dtm version and update it automatically in every release

Related Issues

close #1300

New Behavior (screenshots if needed)

test download.sh
image

upload download.sh to s3 and test it as an user
image

Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
@KeHaohaoke
Copy link
Contributor

LGTM

@aFlyBird0 aFlyBird0 merged commit 6e15b53 into devstream-io:main Dec 5, 2022
@aFlyBird0 aFlyBird0 deleted the feat-upload-dtm-to-s3 branch December 12, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: Better user experience for Chinese users
4 participants