Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Quickstart Workflow Failed With var ImageRepo Error #1308

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Fix: Quickstart Workflow Failed With var ImageRepo Error #1308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5516ead
fix: quickstart workflow failed with var ImageRepo error
daniel-hutao Dec 5, 2022
085dd88
chore: optimize log output
daniel-hutao Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/core-concepts/output.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ tools:
branch: main
repoType: github
vars:
ImageRepo: "ironcore864/golang-demo"
imageRepo: "ironcore864/golang-demo"
sourceRepo:
org: devstream-io
repo: dtm-scaffolding-golang
Expand Down
2 changes: 1 addition & 1 deletion docs/plugins/argocdapp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ tools:
branch: [[ defaultBranch ]]
repoType: github
vars:
ImageRepo: "[[ dockerhubUsername ]]/[[ repoName ]]"
imageRepo: "[[ dockerhubUsername ]]/[[ repoName ]]"
sourceRepo:
org: devstream-io
repo: dtm-scaffolding-golang
Expand Down
2 changes: 1 addition & 1 deletion docs/plugins/repo-scaffolding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ tools:
repo: dtm-scaffolding-golang
repoType: github
vars:
ImageRepo: dtm-test/golang-repo
imageRepo: dtm-test/golang-repo
```

This config will create `dtm-test-golang` repo for user test_owner in GitHub, and the variable ImageRepo will be used for template render.
Expand Down
2 changes: 1 addition & 1 deletion examples/gitops.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ tools:
repo: dtm-scaffolding-golang
repoType: github
vars:
ImageRepo: "[[ dockerhubUsername ]]/[[ repoName ]]"
imageRepo: "[[ dockerhubUsername ]]/[[ repoName ]]"
- name: jira-github-integ
instanceID: default
dependsOn: [ "repo-scaffolding.golang-github" ]
Expand Down
2 changes: 1 addition & 1 deletion examples/quickstart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ tools:
repo: dtm-scaffolding-golang
repoType: github
vars:
ImageRepo: YOUR_DOCKER_USERNAME/go-webapp-devstream-demo
imageRepo: YOUR_DOCKER_USERNAME/go-webapp-devstream-demo
- name: githubactions-golang
instanceID: default
dependsOn: ["repo-scaffolding.golang-github"]
Expand Down
3 changes: 1 addition & 2 deletions internal/pkg/plugin/installer/reposcaffolding/installer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ func InstallRepo(options configmanager.RawOptions) error {
processRepoFileFunc(appName, opts.renderTplConfig()),
)
if err != nil {
log.Warnf("repoScaffolding render repoTemplate failed=> %+v", err)
return fmt.Errorf("render RepoTemplate files failed")
return fmt.Errorf("render RepoTemplate files failed with error: %w", err)
}

// 3. push repo to DestinationRepo
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/show/config/plugins/repo-scaffolding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ tools:
repoType: YOUR_TEMPLATE_REPO_TYPE
# this is used for template render
vars:
ImageRepo: YOUR_DOCKERHUB_REPOSITORY
imageRepo: YOUR_DOCKERHUB_REPOSITORY
2 changes: 1 addition & 1 deletion internal/pkg/show/config/templates/gitops.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ tools:
repo: dtm-scaffolding-golang
repoType: github
vars:
ImageRepo: "[[ dockerhubUsername ]]/[[ repoName ]]"
imageRepo: "[[ dockerhubUsername ]]/[[ repoName ]]"
- name: jira-github-integ
instanceID: default
dependsOn: [ "repo-scaffolding.golang-github" ]
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/show/config/templates/quickstart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
config:
state:
state: # state config, backend can be local, s3 or k8s
backend: local
options:
stateFile: devstream.state
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/yaml/e2e-test-local.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ tools:
branch: [[ defaultBranch ]]
repoType: github
vars:
ImageRepo: "[[ dockerhubUsername ]]/[[ repoName ]]"
imageRepo: "[[ dockerhubUsername ]]/[[ repoName ]]"
sourceRepo:
org: devstream-io
repo: dtm-scaffolding-golang
Expand Down