Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: argocdapp support push helm config files #1312

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Dec 6, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • fix ut error
  • argocdapp support imageRepo options, for project without helm config, we can push valid helm config files to repo.

Related Issues

close #1311, #1296

New Behavior (screenshots if needed)

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@daniel-hutao daniel-hutao merged commit 7856b96 into devstream-io:main Dec 7, 2022
@daniel-hutao daniel-hutao deleted the refactor-argocdapp-support-helm-config-upload branch December 7, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💣 Bug: CI Workflow Failed in configmanager Package
3 participants