Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use git.RepoInfo for all git repo related config #1323

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Dec 9, 2022

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • use git.RepoInfo for all git repo-related config
  • delete useless code

Related Issues

close #1322

New Behavior (screenshots if needed)

@daniel-hutao
Copy link
Member

image
image

Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber force-pushed the refactor-scm-git-options branch from 02591b5 to 81e81a9 Compare December 9, 2022 07:47
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@daniel-hutao daniel-hutao merged commit fd68e14 into devstream-io:main Dec 12, 2022
@daniel-hutao daniel-hutao deleted the refactor-scm-git-options branch December 12, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: refactor git repo struct
3 participants