Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build:Modify GitHub releases URL to aws s3 #1340

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

Shuimo03
Copy link
Contributor

@Shuimo03 Shuimo03 commented Dec 13, 2022

Signed-off-by: Shuimo03 wu1998102@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Because the GitHub releases URL was slow to download before, switching to AWS S3 will change the download speed.

before:
GitHubURL.png

now
aws-s3.png

Related Issues

issuees:#1314

New Behavior (screenshots if needed)

@Shuimo03 Shuimo03 requested a review from a team as a code owner December 13, 2022 08:02
internal/pkg/upgrade/upgrade.go Outdated Show resolved Hide resolved
@daniel-hutao
Copy link
Member

DevStream community follows the conventional commits specification. Please read our doc and update your commit message.

Copy link
Member

@aFlyBird0 aFlyBird0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! @Shuimo03

I've left some comments in the hope that we can continue to improve the code together.

One more tiny one that has little impact on the code itself.

It looks like this branch of yours hasn't pulled the latest code from the main branch of dtm in a long time. I recommend running git fetch upstream && git rebase upstream/main.

For more guidance on GitHub collaboration you can read this blog: https://blog.devstream.io/posts/open-a-pr-in-github/

internal/pkg/upgrade/upgrade.go Outdated Show resolved Hide resolved
@aFlyBird0
Copy link
Member

I noticed that lint commit message CI failed, this article could help you:

DevStream community follows the conventional commits specification. Please read our doc and update your commit message.

@aFlyBird0
Copy link
Member

aFlyBird0 commented Dec 13, 2022

After changing your code and updating commit messages, you could use git rebase to make commit history more clear:

https://blog.devstream.io/posts/open-a-pr-in-github/#622-ide-%E9%87%8C%E5%90%88%E5%B9%B6-commits

And, at last, just run git push -f

@Shuimo03

Signed-off-by: shuimo03 <wu1998102@gmail.com>
@aFlyBird0 aFlyBird0 removed their assignment Jan 13, 2023
@Shuimo03 Shuimo03 requested review from aFlyBird0 and daniel-hutao and removed request for daniel-hutao and aFlyBird0 January 14, 2023 11:35
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daniel-hutao daniel-hutao merged commit a40893f into devstream-io:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants