-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build:Modify GitHub releases URL to aws s3 #1340
Conversation
DevStream community follows the conventional commits specification. Please read our doc and update your commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! @Shuimo03
I've left some comments in the hope that we can continue to improve the code together.
One more tiny one that has little impact on the code itself.
It looks like this branch of yours hasn't pulled the latest code from the main
branch of dtm in a long time. I recommend running git fetch upstream && git rebase upstream/main
.
For more guidance on GitHub collaboration you can read this blog: https://blog.devstream.io/posts/open-a-pr-in-github/
I noticed that DevStream community follows the conventional commits specification. Please read our doc and update your commit message. |
After changing your code and updating commit messages, you could use https://blog.devstream.io/posts/open-a-pr-in-github/#622-ide-%E9%87%8C%E5%90%88%E5%B9%B6-commits And, at last, just run |
0f1c2f3
to
2031a31
Compare
Signed-off-by: shuimo03 <wu1998102@gmail.com>
2031a31
to
77e68ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Shuimo03 wu1998102@gmail.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
Because the GitHub releases URL was slow to download before, switching to AWS S3 will change the download speed.
before:
now
Related Issues
issuees:#1314
New Behavior (screenshots if needed)