Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: gitops-apps cn #1358

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

aFlyBird0
Copy link
Member

Signed-off-by: Bird aflybird0@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Related Issues

New Behavior (screenshots if needed)

Signed-off-by: Bird <aflybird0@gmail.com>
Copy link
Contributor

@steinliber steinliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc looks like a quickstart of apps, maybe you can rename this doc and add config to internal/pkg/show/config/templates/ to support showing this config.

docs/best-practices/apps.zh.md Outdated Show resolved Hide resolved
docs/best-practices/apps.zh.md Outdated Show resolved Hide resolved
@aFlyBird0
Copy link
Member Author

This doc looks like a quickstart of apps, maybe you can rename this doc and add config to internal/pkg/show/config/templates/ to support showing this config.

done in https://github.com/devstream-io/devstream/pull/1356/files ,this pr is just a translation

Signed-off-by: Bird <aflybird0@gmail.com>
@devstream-io devstream-io deleted a comment from aFlyBird0 Dec 19, 2022
@daniel-hutao daniel-hutao merged commit 941be7b into devstream-io:main Dec 20, 2022
@aFlyBird0 aFlyBird0 deleted the docs-gitops-apps-cn branch January 5, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants