Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reposcaffolding plugin use encode logic #1404

Merged
merged 1 commit into from
Jan 3, 2023
Merged

refactor: reposcaffolding plugin use encode logic #1404

merged 1 commit into from
Jan 3, 2023

Conversation

steinliber
Copy link
Contributor

@steinliber steinliber commented Dec 30, 2022 •
edited
Loading

Signed-off-by: Meng JiaFeng jiafeng.meng@merico.dev

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • add PluginDecoder to process git.RepoInfo data default config
  • move reposcaffolding logic from installer to plugin

Related Issues

close #1403

New Behavior (screenshots if needed)

@steinliber
refactor: reposcaffolding plugin use encode logic
7a29ba2 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber requested a review from a team as a code owner December 30, 2022 03:17
aFlyBird0
aFlyBird0 approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@aFlyBird0 aFlyBird0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-hutao daniel-hutao merged commit 9366c01 into devstream-io:main Jan 3, 2023
@daniel-hutao daniel-hutao deleted the refactor-plugin-option-encode branch January 3, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aFlyBird0 aFlyBird0 aFlyBird0 approved these changes

@daniel-hutao daniel-hutao daniel-hutao approved these changes

Assignees

@daniel-hutao daniel-hutao

@IronCore864 IronCore864

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🍀 Proposal: default decoder for plugin options
4 participants
@steinliber @daniel-hutao @aFlyBird0 @IronCore864