Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add plugin outputs reference #323

Merged
merged 7 commits into from
Mar 18, 2022
Merged

feat: add plugin outputs reference #323

merged 7 commits into from
Mar 18, 2022

Conversation

lfbdev
Copy link
Contributor

@lfbdev lfbdev commented Mar 15, 2022 •
edited
Loading

Summary

Use format: ${{ TOOL_NAME.TOOL_KIND.outputs.var}} to ref the outputs of other plugins

Description

Describe what this PR does and what problems it tries to solve in a few sentences.

Related Issues

#324

Screenshots

image

@lfbdev lfbdev added the enhancement New feature or request label Mar 15, 2022
@lfbdev lfbdev self-assigned this Mar 15, 2022
@lfbdev lfbdev marked this pull request as ready for review March 15, 2022 03:01
@lfbdev lfbdev requested review from daniel-hutao and IronCore864 and removed request for daniel-hutao March 15, 2022 03:01
IronCore864
IronCore864 requested changes Mar 15, 2022
View reviewed changes
internal/pkg/plugin/trellogithub/create.go Outdated Show resolved Hide resolved
internal/pkg/plugin/trellogithub/helper.go Outdated Show resolved Hide resolved
internal/pkg/plugin/trellogithub/update.go Outdated Show resolved Hide resolved
internal/pkg/plugin/trellogithub/workflow.go Outdated Show resolved Hide resolved
internal/pkg/pluginengine/change.go Outdated Show resolved Hide resolved
internal/pkg/pluginengine/change.go Outdated Show resolved Hide resolved
internal/pkg/pluginengine/change.go Outdated Show resolved Hide resolved
internal/pkg/pluginengine/change.go Show resolved Hide resolved
internal/pkg/pluginengine/change.go Outdated Show resolved Hide resolved
internal/pkg/pluginengine/change.go Outdated Show resolved Hide resolved
@IronCore864
Copy link
Member

I also suggest that we add some unit tests to cover this change. We can add many irregular test cases so that abnormal user input won't break our program.

@IronCore864
Copy link
Member

FYI: it seems the latest lint failed. Please fix.

@lfbdev lfbdev force-pushed the feat-output-ref branch 3 times, most recently from 26f5185 to 6cbd64e Compare March 16, 2022 07:47
@lfbdev lfbdev requested a review from IronCore864 March 16, 2022 14:24
@lfbdev lfbdev force-pushed the feat-output-ref branch 4 times, most recently from 04a10a1 to 6cb7b27 Compare March 18, 2022 00:32
daniel-hutao
daniel-hutao requested changes Mar 18, 2022
View reviewed changes
Copy link
Member

@daniel-hutao daniel-hutao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment below.

docs/plugins/trello-github-integ_plugin.md Show resolved Hide resolved
docs/plugins/trello-github-integ_plugin.md Show resolved Hide resolved
docs/plugins/trello-github-integ_plugin.md Outdated Show resolved Hide resolved
internal/pkg/plugin/trello/trello.go Outdated Show resolved Hide resolved
internal/pkg/plugin/trellogithub/create.go Outdated Show resolved Hide resolved
internal/pkg/pluginengine/change_helper.go Show resolved Hide resolved
internal/pkg/pluginengine/fillRefValueWithOutputs_test.go Show resolved Hide resolved
internal/pkg/pluginengine/getOutputs_test.go Show resolved Hide resolved
internal/pkg/statemanager/manager.go Show resolved Hide resolved
pkg/util/trello/trello.go Outdated Show resolved Hide resolved
@daniel-hutao
Copy link
Member

Please don't forget to clear the commits record, then push -f, because we are no longer squash online.

@lfbdev lfbdev requested a review from daniel-hutao March 18, 2022 08:01
@daniel-hutao daniel-hutao merged commit 76ac5ba into main Mar 18, 2022
@lfbdev lfbdev deleted the feat-output-ref branch March 18, 2022 08:37
@lfbdev lfbdev restored the feat-output-ref branch March 21, 2022 13:18
@IronCore864 IronCore864 deleted the feat-output-ref branch March 23, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronCore864 IronCore864 IronCore864 approved these changes

@daniel-hutao daniel-hutao daniel-hutao approved these changes

Assignees

@lfbdev lfbdev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfbdev @IronCore864 @daniel-hutao