Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor gitlab-ce-docker and fix some docs format #829

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

aFlyBird0
Copy link
Member

@aFlyBird0 aFlyBird0 commented Jul 8, 2022

Signed-off-by: Bird aflybird0@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  1. some refactor in gitlab-ce-docker
  2. fix the check of deleting volumes
  3. show access URL after installing gitlab-ce-docker
  4. delete useless ut
  5. update docs

Anything else

Already tested locally

Signed-off-by: Bird <aflybird0@gmail.com>
@aFlyBird0 aFlyBird0 requested a review from daniel-hutao July 8, 2022 07:47
@aFlyBird0 aFlyBird0 requested review from IronCore864 and a team as code owners July 8, 2022 07:47
@algobot76
Copy link
Contributor

Is it necessary to remove deletion_test.go?

Copy link
Contributor

@algobot76 algobot76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Bird <aflybird0@gmail.com>
@aFlyBird0 aFlyBird0 assigned daniel-hutao and unassigned steinliber Jul 19, 2022
@steinliber steinliber merged commit 6cb1228 into devstream-io:main Jul 19, 2022
@aFlyBird0 aFlyBird0 deleted the chore branch July 22, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants