Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh issue on add project & host url update and process undefined on dev server #1381

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

eshankvaish
Copy link
Contributor

@eshankvaish eshankvaish commented Oct 13, 2023

Description

Fixes devtron-labs/devtron#4088

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@eshankvaish eshankvaish self-assigned this Oct 13, 2023
@github-actions github-actions bot added PR:Issue-verification-failed PR:Issue-verification-failed PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Oct 13, 2023
vivek-devtron
vivek-devtron previously approved these changes Oct 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@eshankvaish eshankvaish merged commit 497acad into main Oct 13, 2023
5 of 6 checks passed
@eshankvaish eshankvaish deleted the bugfix-accessibility-4088 branch October 13, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Page refresh on pressing Enter while adding project in global configuration
2 participants