Marged refactoring #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/git/Watcher.go
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9190503 | Triggered | Username Password | cbd5a5d | pkg/git/RepositoryManagerIT_test.go | View secret |
| 9190503 | Triggered | Username Password | 51743fc | pkg/git/RepositoryManagerIT_test.go | View secret |
| 9190503 | Triggered | Username Password | ab22c47 | pkg/git/RepositoryManagerIT_test.go | View secret |
| 9190503 | Triggered | Username Password | e8a34c6 | pkg/git/RepositoryManagerIT_test.go | View secret |
| 6669478 | Triggered | PGP Private Key | e9f636f | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669478 | Triggered | PGP Private Key | 586efbd | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669478 | Triggered | PGP Private Key | 9ffc8e7 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669478 | Triggered | PGP Private Key | 87ebad5 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669479 | Triggered | PGP Private Key | e9f636f | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669479 | Triggered | PGP Private Key | 586efbd | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669479 | Triggered | PGP Private Key | 9ffc8e7 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669479 | Triggered | PGP Private Key | 87ebad5 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669480 | Triggered | PGP Private Key | e9f636f | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669480 | Triggered | PGP Private Key | 586efbd | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669480 | Triggered | PGP Private Key | 9ffc8e7 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669480 | Triggered | PGP Private Key | 87ebad5 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669481 | Triggered | PGP Private Key | e9f636f | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669481 | Triggered | PGP Private Key | 586efbd | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669481 | Triggered | PGP Private Key | 9ffc8e7 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669481 | Triggered | PGP Private Key | 87ebad5 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669482 | Triggered | PGP Private Key | e9f636f | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669482 | Triggered | PGP Private Key | 586efbd | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669482 | Triggered | PGP Private Key | 9ffc8e7 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669482 | Triggered | PGP Private Key | 87ebad5 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669483 | Triggered | PGP Private Key | e9f636f | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669483 | Triggered | PGP Private Key | 586efbd | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669483 | Triggered | PGP Private Key | 9ffc8e7 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669483 | Triggered | PGP Private Key | 87ebad5 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669484 | Triggered | PGP Private Key | e9f636f | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669484 | Triggered | PGP Private Key | 586efbd | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669484 | Triggered | PGP Private Key | 9ffc8e7 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
| 6669484 | Triggered | PGP Private Key | 87ebad5 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
fix : version up
* adding git commit message truncation logic for large messages * first commit draft * cleaning dead code * added commit count * fix git format in cmd * added interfaces * comments * removing output * minor restructuring * removing deuplicacy for OpenNewRepo * changes * fixes * wire * old story refactor * fixes for IT tests * cleaning * refactorings * minor * test fixes * test fixes * test fixes * PR comments * removing old changes * cleaning up * wire * minor changes * added comments on interface methods * next error handling * added timeout and context in one flow * added timeouts * remaning flows * minor changes * renaming to gitCtx * added command timeout * added command timeout * moving cancel defer in poller * renaming * added command level timeouts * fix * minor * removing process timeout * refactoring * cli for analytics * changes * changes * minor * adding gogit timeout * debugging * testing fix * fixes * fixes * minor refactor * pr comments * fixed it tests * common-lib upgrade * common lib from main * fixes-be * adding support for last seen hash * fix for history being overwritten * fixing for empty history * changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.