Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ldap cluster connector #1904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phiremande
Copy link

Overview

This changes implements a new ldapcluster connector, which helps configure multiple ldap servers and requests are tried in round robin fashion to these servers with an affinity to last active server.

What this PR does / why we need it

#1548

Special notes for your reviewer

Does this PR introduce a user-facing change?

Introduces a new connector 'ldapcluster', which helps configure a cluster of ldap servers.  This can be used to provide fault tolerant LDAP connection.

Signed-off-by: Pradeep Hiremande <16595434+phiremande@users.noreply.github.com>
@scottd018
Copy link

+1 to this MR. Have an enterprise customer that wishes to use Dex but has concerns with lack of redundancy provided by the connector.

@sagikazarmark
Copy link
Member

Thanks for the contribution. TBH, I don't think this is the best way to tackle the problem. I think it should be handled on the connection/LDAP connection level.

I asked about an existing solution in the LDAP client repo. Let's see what they answer.

@stefanmcshane
Copy link

Hi All,

We are discussing expanding the reach of the ldap library, and adding support for clustering connections.

Any ideas or usecases you have would be appreciated on go-ldap/ldap#314

Thanks,
Stefan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants