fix: prevent cross-site scripting for the device flow #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabokihms
force-pushed
the
cwe-79-device-code
branch
from
c2a081f to
71ab49c
Compare
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
nabokihms
force-pushed
the
cwe-79-device-code
branch
from
71ab49c to
3d5a3be
Compare
sagikazarmark
approved these changes
Jun 30, 2022
xtremerui
pushed a commit
to concourse/dex
that referenced
this pull request
Aug 2, 2022
<!-- Release notes generated using configuration in .github/release.yml at v2.33.x --> ## What's Changed ### Exciting New Features 🎉 * add PKCE support to device code flow by @bobcallaway in dexidp#2575 ### Enhancements 🚀 * Limit the amount of objects we attempt to GC on each cycle by @kellyma2 in dexidp#2524 * Use GitLab's refresh_token during Refresh. by @dhaus67 in dexidp#2352 * Add domainHint parameter to Microsoft Connector by @josephtknight in dexidp#2586 * add config to explicitly set scopes for microsoft connector by @bobcallaway in dexidp#2582 ### Bug Fixes 🐛 * fix: prevent cross-site scripting for the device flow by @nabokihms in dexidp#2468 * grpc-client: Do not crash on empty response by @bbusse in dexidp#2584 ### Dependency Updates ⬆️ * build(deps): bump helm/kind-action from 1.2.0 to 1.3.0 by @dependabot in dexidp#2555 * build(deps): bump aquasecurity/trivy-action from 0.3.0 to 0.4.0 by @dependabot in dexidp#2557 * build(deps): bump github.com/stretchr/testify from 1.7.2 to 1.8.0 by @dependabot in dexidp#2577 * build(deps): bump aquasecurity/trivy-action from 0.4.0 to 0.5.1 by @dependabot in dexidp#2576 * build(deps): bump mheap/github-action-required-labels from 1 to 2 by @dependabot in dexidp#2565 * build(deps): bump google.golang.org/api from 0.82.0 to 0.86.0 by @dependabot in dexidp#2574 * build(deps): bump github.com/spf13/cobra from 1.4.0 to 1.5.0 by @dependabot in dexidp#2560 * build(deps): bump aquasecurity/trivy-action from 0.5.1 to 0.6.0 by @dependabot in dexidp#2602 * build(deps): bump alpine from 3.16.0 to 3.16.1 by @dependabot in dexidp#2598 * build(deps): bump golang from 1.18.3-alpine3.15 to 1.18.4-alpine3.15 by @dependabot in dexidp#2592 * build(deps): bump github.com/sirupsen/logrus from 1.8.1 to 1.9.0 by @dependabot in dexidp#2599 * build(deps): bump github.com/go-ldap/ldap/v3 from 3.4.2 to 3.4.4 by @dependabot in dexidp#2606 * build(deps): bump google.golang.org/api from 0.86.0 to 0.89.0 by @dependabot in dexidp#2605 * build(deps): bump aquasecurity/trivy-action from 0.6.0 to 0.6.1 by @dependabot in dexidp#2604 ## New Contributors * @kellyma2 made their first contribution in dexidp#2524 * @josephtknight made their first contribution in dexidp#2586 * @bbusse made their first contribution in dexidp#2584 **Full Changelog**: dexidp/dex@v2.32.0...v2.33.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: m.nabokikh maksim.nabokikh@flant.com
Overview
It is possible to inject the malicious code by redirecting the user to the callback URL.
What this PR does / why we need it
This fix doesn't look urgent. The severity of related CWE equals Medium, and frauds need access to participants of the flow.
Special notes for your reviewer
https://cwe.mitre.org/data/definitions/79.html
Does this PR introduce a user-facing change?