Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot resolve macro that falls into another month #10

Closed
dezlov opened this issue Aug 15, 2019 · 3 comments
Closed

Cannot resolve macro that falls into another month #10

dezlov opened this issue Aug 15, 2019 · 3 comments
Labels
bug

Comments

@dezlov
Copy link
Owner

dezlov commented Aug 15, 2019 •
edited
Loading

A macro for finding a week day has been adjusted for zone Asia/Hong_Kong in tzdata2019b such that the target day falls into another month, which is currently cannot be handled by PascalTZ library.

See the extracts for "Sun>=28" and "Sun>=31":

Rule	HK	1948	1952	-	Oct	Sun>=28	3:30s	0	-
Rule	HK	1953	1964	-	Oct	Sun>=31	3:30	0	-

Error raised in MacroFirstWeekDay function:

No valid first week day for "Sunday" after 1952.10.28
@dezlov dezlov added the bug label Aug 15, 2019
@unihedron
Copy link

Is there any workaround for this?

dezlov added a commit that referenced this issue Dec 8, 2019
@dezlov
Handle weekday macros which fall into another month.
6d93249 
For example, Asia/Hong_Kong zone in tzdata2019b include weekday macros "Sun>=28" and "Sun>=31".

See issue #10.
@dezlov
Copy link
Owner Author

dezlov commented Dec 8, 2019

@unihedron It was resolved the same day, but didn't get pushed for some reason.

Please try the latest master branch.

@dezlov dezlov closed this as completed Dec 8, 2019
@unihedron
Copy link

Works fine. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unihedron @dezlov