Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace .rc script by .res resource file in order to avoid issues with windres #11

Merged
merged 1 commit into from
Mar 7, 2020

Conversation

wp-xyz
Copy link
Contributor

@wp-xyz wp-xyz commented Feb 27, 2020

Replace .rc script by .res resource file in order to avoid issues with windres (https://forum.lazarus.freepascal.org/index.php/topic,48691.msg350922.html).
Add additional high-dpi palette icons.

@dezlov dezlov changed the title Resource Replace .rc script by .res resource file in order to avoid issues with windres Mar 7, 2020
@dezlov
Copy link
Owner

dezlov commented Mar 7, 2020

Thanks for the changes. Looks good.

@dezlov dezlov merged commit 2e0ca7d into dezlov:master Mar 7, 2020
@dezlov
Copy link
Owner

dezlov commented Mar 7, 2020

For those encountering the same problem with windres prior to these changes, you need to replace \ with / in the *.rc file to fix the issue.

@wp-xyz
Copy link
Contributor Author

wp-xyz commented Mar 15, 2020

The new revision is not yet available through OPM. You should give the new version a new version number and pack the files into a zip in your "archive" like you did before. Then you should update the update.json file with the storage location of the new zip. This would make the new version available for OPM installation from the "third-party repository". In order to bring it into the "official repository" you should contact forum user GetMem, the maintainer of OPM, and ask him to update the package in OPM.

@dezlov
Copy link
Owner

dezlov commented Mar 18, 2020

I sent a message to GetMem asking to update the package in the OPM repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants