TrampleCrop Handler #868
Merged
TrampleCrop Handler #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sandertv
requested changes
May 26, 2024
There was a problem hiding this comment.
I think it might be more suitable to have a HandleCropTrample method in world.Handler. That way we don't have to duplicate this method for every entity (because ultimately, all entities can trample crops). That would mean calling this event in the EntityLand method of block.Farmland.
|
I was looking through issues when I saw this and I saw the discussion that you and Tal both thought it would be better to have it in a player/entity handler |
|
Good point, let me think about it a bit more. |
Sandertv
reviewed
Aug 25, 2024
…rample # Conflicts: # server/player/handler.go
|
should be good to merge |
|
added position of crop users might find it useful if they just want to cancel it in a certain area |
Sandertv
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements TrampleCrop handler to prevent players from trampling crops.