Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise bounds on Cassette & CuArrays #59

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Raise bounds on Cassette & CuArrays #59

merged 1 commit into from
Apr 26, 2020

Conversation

mcabbott
Copy link
Contributor

This allows Cassette 0.3 and CuArrays 2, and its friends, after which tests still pass on Julia 1.4.

Tests still fail on nightly, the message I get is this:

grad: basic: Error During Test at /Users/me/.julia/dev/Yota/test/test_grad.jl:8
  Got exception outside of a @test
  TypeError: in new, expected Union{Nothing, Symbol}, got a value of type String
  Stacktrace:
   [1] LineNumberNode(::Int64, ::Any) at ./boot.jl:372
   [2] generate_function_expr(::Tape) at /Users/me/.julia/dev/Yota/src/compile.jl:127
   [3] compile(::Tape; bind::Bool, ret_grad::Bool) at /Users/me/.julia/dev/Yota/src/compile.jl:182
   [4] compile(::Tape) at /Users/me/.julia/dev/Yota/src/compile.jl:182
   [5] compile!(::Tape) at /Users/me/.julia/dev/Yota/src/compile.jl:188
   [6] grad(::Function, ::Array{Float64,2}, ::Vararg{Any,N} where N; dynamic::Bool) at /Users/me/.julia/dev/Yota/src/grad.jl:316

@dfdx
Copy link
Owner

dfdx commented Apr 26, 2020

Perfect, thank you!
Regarding error on nightly, I think I know the reason and it should be easily fixable, I'll check it later today.

@dfdx dfdx merged commit 5f2029f into dfdx:master Apr 26, 2020
@mcabbott mcabbott deleted the versions branch April 26, 2020 07:01
@dfdx
Copy link
Owner

dfdx commented Apr 27, 2020

Just FYI: I fixed an error on Julia nightly and submitted PR for a new version, thanks again for fixing dependency versions.

@mcabbott
Copy link
Contributor Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants