Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resources for Git with DevOps manual #102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aporsch1
Copy link

Overview of changes

I added the callout with the link requested in Issue #99

Why are these changes being made?

From issue

Detailed description of changes

I added the callout (used callout with title) and then added the link (given in issue) to the callout.

Issue ticket number/s and link

Issue #99 (#99)

Checklist before requesting a review

  • [ x] I have checked the contributing guidelines
  • [ x] I have checked for and linked any relevant issues that this may resolve
  • [ x] I have checked that these changes build locally
  • [ x] I understand that if merged into main, these changes will be publicly available

Signed-off-by: Abe <108027459+aporsch1@users.noreply.github.com>
@jen-machin
Copy link
Contributor

Hi @aporsch1, thanks for fixing this issue for us 😄 How did you find our repo, if you don't mind me asking?

@aporsch1
Copy link
Author

I am taking a class on open source software, right now, and we had to makea contribution to a project. I figured this seemed like a nice place to make a small contribution. I hope I was able to help a bit

Copy link
Contributor

@Lsnaathorst1 Lsnaathorst1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aporsch1,

Thanks again so much for taking a look at this for us! Apologies in the delay in reviewing.

The callout tip box is great - we have moved to using the .callouts for notes, tips and warnings to keep consistency so that is perfect.

On the link itself, we try to avoid using language like 'link here' for accessibility reasons. You can see more information on this in the creating hyperlinks section of our analysts guide: https://dfe-analytical-services.github.io/analysts-guide/writing-visualising/writing.html#creating-hyperlinks

Would you want to have a go at amending the link based on the above? We can amend if not, but wanted to give you the chance so that we can approve your changes for your project!

Thank you!

@Lsnaathorst1
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants