Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numberstring and more detailed indicator unit notes #83

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

cjrace
Copy link
Contributor

@cjrace cjrace commented Sep 5, 2024

Overview of changes

Adding numberstring as an acceptable indicator_unit.

Why are these changes being made?

We'd added it into EES this week, so the guidance should match to tell users it's an option.

Detailed description of changes

Added a new table that lists all acceptable values in it with a quick description of what they do.

image

Weirdly, I think the missing TOC issue might be fixed as a result of these changes now too? @rmbielby @jen-machin

image

Issue ticket number/s and link

None

Checklist before requesting a review

  • I have checked the contributing guidelines
  • I have checked for and linked any relevant issues that this may resolve
  • I have checked that these changes build locally
  • I understand that if merged into main, these changes will be publicly available

Signed-off-by: Cam Race <52536248+cjrace@users.noreply.github.com>
@cjrace cjrace marked this pull request as ready for review September 5, 2024 17:10
@cjrace cjrace removed their assignment Sep 5, 2024
@cjrace cjrace added the enhancement New feature or request label Sep 5, 2024
@cjrace
Copy link
Contributor Author

cjrace commented Sep 5, 2024

@jen-machin jen-machin assigned jen-machin and unassigned jen-machin Sep 6, 2024
Copy link
Contributor

@jen-machin jen-machin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor change

@cjrace cjrace merged commit f9e76c4 into main Sep 6, 2024
@cjrace cjrace deleted the add-numberstring branch September 6, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants