-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: textual encoding for ICRC-1 account #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change proposes a textual encoding for ICRC-1 accounts.
1 task
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Apr 18, 2023
# Motivation Bump ic-js to implement what might be the definitive textual encoding for ICRC-1 account. Source of encoding 👉 dfinity/ICRC-1#98 # PRs - [x] dfinity/ic-js#308 # Changes - bump ic-js - test: fix mock data from / to that were incorrectly set - test: use object param to avoid from / to to be incorrectly set in the future - test: partial mock subaccount array isn't supported anymore to encode/decode ICRC account as the decoded checks the validity of the checksum
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Apr 18, 2023
# Motivation Bump ic-js to implement what might be the definitive textual encoding for ICRC-1 account. Source of encoding 👉 dfinity/ICRC-1#98 # PRs - [x] dfinity/ic-js#308 # Changes - bump ic-js - test: fix mock data from / to that were incorrectly set - test: use object param to avoid from / to to be incorrectly set in the future - test: partial mock subaccount array isn't supported anymore to encode/decode ICRC account as the decoded checks the validity of the checksum
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Apr 18, 2023
# Motivation Bump ic-js to implement what might be the definitive textual encoding for ICRC-1 account. Source of encoding 👉 dfinity/ICRC-1#98 # PRs - [x] dfinity/ic-js#308 # Changes - bump ic-js - test: fix mock data from / to that were incorrectly set - test: use object param to avoid from / to to be incorrectly set in the future - test: partial mock subaccount array isn't supported anymore to encode/decode ICRC account as the decoded checks the validity of the checksum
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Apr 18, 2023
# Motivation Bump ic-js to implement what might be the definitive textual encoding for ICRC-1 account. Source of encoding 👉 dfinity/ICRC-1#98 # PRs - [x] dfinity/ic-js#308 # Changes - bump ic-js - test: fix mock data from / to that were incorrectly set - test: use object param to avoid from / to to be incorrectly set in the future - test: partial mock subaccount array isn't supported anymore to encode/decode ICRC account as the decoded checks the validity of the checksum
skilesare
reviewed
Apr 21, 2023
can we provide this as a https://mops.one package? |
I fear only after mops.one implements team ownership for packages (ideally, but not necessarily, using GitHub groups). |
This might be helpful since motoko is wishy washy with blob an [nat8]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change proposes a textual encoding for ICRC-1 accounts.