Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ObservableLog no longer extends Function #887

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

krpeacock
Copy link
Contributor

Description

Funded app reported that in Chrome browser extensions, the Function / Proxy implementation was being rejected under rules blocking the use of eval.

How Has This Been Tested?

Once Funded has tested the changes in their extension, this can be merged

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner May 30, 2024 22:40
Copy link
Contributor

github-actions bot commented May 30, 2024

size-limit report 📦

Path Size
@dfinity/agent 85.8 KB (-0.12% 🔽)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 4.97 KB (0%)
@dfinity/auth-client 60.8 KB (-0.06% 🔽)
@dfinity/assets 80.5 KB (-0.05% 🔽)
@dfinity/identity 58 KB (-0.1% 🔽)
@dfinity/identity-secp256k1 266.21 KB (-0.04% 🔽)

@mzibara
Copy link

mzibara commented May 31, 2024

Approved on PLUG side, thank you!

@krpeacock krpeacock merged commit a42708c into main Jun 5, 2024
16 checks passed
@krpeacock krpeacock deleted the kai/remove-extend-function branch June 5, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants