Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated outdated urls in sample #888

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

r-birkner
Copy link
Contributor

@r-birkner r-birkner commented May 31, 2024

Description

The URLs used in the sample are outdated and do not work anymore. I replaced them with the current URLs. However, I couldn't fix the canister ID as I am not sure what canister it should be.

Fixes # (issue)

How Has This Been Tested?

I updated it and ran it manually. Of course I got an error because the canister doesn't exist anymore, but at least it went through a boundary node and hit a replica.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@r-birkner r-birkner requested a review from a team as a code owner May 31, 2024 15:04
@r-birkner r-birkner changed the title updated outdated urls in sample fix: updated outdated urls in sample May 31, 2024
@krpeacock krpeacock merged commit 63c913d into dfinity:main Jun 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants