Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update management canister interface with wasm_memory_limit #894

Closed
wants to merge 1 commit into from
Closed

chore: update management canister interface with wasm_memory_limit #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- chore: updates agent error response to read "Gateway returns error" instead of "Server"`
- chore: updates dfinity/conventional-pr-title-action to v4.0.0
- chore: updates dfinity/conventional-pr-title-action to v3.2.0
- update management canister interface with `wasm_memory_limit`

## [1.3.0] - 2024-05-01

Expand Down
2 changes: 2 additions & 0 deletions packages/agent/src/canisters/management.did
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ type canister_settings = record {
freezing_threshold : opt nat;
reserved_cycles_limit : opt nat;
log_visibility : opt log_visibility;
wasm_memory_limit : opt nat;
};

type definite_canister_settings = record {
Expand All @@ -22,6 +23,7 @@ type definite_canister_settings = record {
freezing_threshold : nat;
reserved_cycles_limit : nat;
log_visibility : log_visibility;
wasm_memory_limit : nat;
};

type change_origin = variant {
Expand Down
2 changes: 2 additions & 0 deletions packages/agent/src/canisters/management_idl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ export default ({ IDL }) => {
controllers: IDL.Vec(IDL.Principal),
reserved_cycles_limit: IDL.Nat,
log_visibility: log_visibility,
wasm_memory_limit: IDL.Nat,
memory_allocation: IDL.Nat,
compute_allocation: IDL.Nat,
});
Expand Down Expand Up @@ -152,6 +153,7 @@ export default ({ IDL }) => {
controllers: IDL.Opt(IDL.Vec(IDL.Principal)),
reserved_cycles_limit: IDL.Opt(IDL.Nat),
log_visibility: IDL.Opt(log_visibility),
wasm_memory_limit: IDL.Opt(IDL.Nat),
memory_allocation: IDL.Opt(IDL.Nat),
compute_allocation: IDL.Opt(IDL.Nat),
});
Expand Down
2 changes: 2 additions & 0 deletions packages/agent/src/canisters/management_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export interface canister_settings {
controllers: [] | [Array<Principal>];
reserved_cycles_limit: [] | [bigint];
log_visibility: [] | [log_visibility];
wasm_memory_limit: [] | [bigint];
memory_allocation: [] | [bigint];
compute_allocation: [] | [bigint];
}
Expand Down Expand Up @@ -153,6 +154,7 @@ export interface definite_canister_settings {
controllers: Array<Principal>;
reserved_cycles_limit: bigint;
log_visibility: log_visibility;
wasm_memory_limit: bigint;
memory_allocation: bigint;
compute_allocation: bigint;
}
Expand Down