Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AllowedViewers to LogVisibility enum #588

Merged
merged 5 commits into from
Sep 6, 2024
Merged

feat: add AllowedViewers to LogVisibility enum #588

merged 5 commits into from
Sep 6, 2024

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Aug 27, 2024 •
edited
Loading

Description

This PR adds a new AllowedViewers variant to LogVisibility enum of the management canister API.

Fixes # (issue): SDK-1800

How Has This Been Tested?

Regular CI.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@maksymar maksymar marked this pull request as ready for review August 27, 2024 12:55
@maksymar maksymar requested a review from a team as a code owner August 27, 2024 12:55
maksymar
maksymar commented Aug 27, 2024
View reviewed changes
ref-tests/tests/ic-ref.rs Outdated Show resolved Hide resolved
@adamspofford-dfinity adamspofford-dfinity merged commit c19d1b6 into dfinity:main Sep 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamspofford-dfinity adamspofford-dfinity adamspofford-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maksymar @adamspofford-dfinity