Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add some conversion methods to AccountIdentifier in ic-ledger-types #352

Merged
merged 7 commits into from
Jul 4, 2023
Merged

feat: Add some conversion methods to AccountIdentifier in ic-ledger-types #352

merged 7 commits into from
Jul 4, 2023

Conversation

witter-deland
Copy link
Contributor

@witter-deland witter-deland commented Dec 30, 2022 •
edited
Loading

Description

Add some conversion methods to AccountIdentifier for better conversion between types

Fixes # (issue)

How Has This Been Tested?

Code from the already tested ic repository

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ghost ghost added the cla:agreed label Dec 30, 2022
@roman-kashitsyn
Copy link
Contributor

If we're copying some code, it would be great to copy the test suite for it as well :)

@witter-deland
Copy link
Contributor Author

Good idea

If we're copying some code, it would be great to copy the test suite for it as well :)

roman-kashitsyn
roman-kashitsyn approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@roman-kashitsyn roman-kashitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

library/ic-ledger-types/src/lib.rs Show resolved Hide resolved
@roman-kashitsyn roman-kashitsyn enabled auto-merge (squash) July 4, 2023 06:00
@roman-kashitsyn roman-kashitsyn merged commit d06afe8 into dfinity:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-kashitsyn roman-kashitsyn roman-kashitsyn approved these changes

Assignees
No one assigned
Labels
cla:agreed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@witter-deland @roman-kashitsyn @lwshang