New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert MSRV #421

Merged

lwshang merged 1 commit into main from lwshang/msrv

Aug 4, 2023

Contributor

lwshang commented Aug 4, 2023

For library projects, we should not change the rust-version line in Cargo.toml. Because that field restricts the minimum supported Rust version (MSRV) of the crate which will enforce the dependent crates/projects to upgrade their MSRV too, i.e. the change is contagious. We should avoid updating the field as mush as we can. And we should use the same version in CI to guarantee the MSRV.

Revert MSRV and add some tips for maintenance.


          Revert MSRV

275f80a

lwshang mentioned this pull request

chore: revert MSRV dfinity/agent-rs#456

Merged

adamspofford-dfinity approved these changes

View reviewed changes

lwshang merged commit 0f674bd into main

lwshang deleted the lwshang/msrv branch

August 4, 2023 18:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet