Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unify Rust toolchain version #429

Merged
merged 11 commits into from
Sep 21, 2023
Merged

chore: unify Rust toolchain version #429

merged 11 commits into from
Sep 21, 2023

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Sep 20, 2023 •
edited
Loading

Description

MSRV is increased to 1.66.0 because candid-extractor's dependency wasmtime requires it.

There will be only two places specify Rust toolchain version:

  • Cargo.toml
  • rust-toolchain.toml

They should sync with each other.

How Has This Been Tested?

Check the actions log.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review September 20, 2023 19:27
@lwshang lwshang requested a review from a team as a code owner September 20, 2023 19:27
@lwshang lwshang changed the title chore: override Rust toolchain in CI chore: unify Rust toolchain version Sep 21, 2023
@lwshang lwshang merged commit 0ef0353 into main Sep 21, 2023
@lwshang lwshang deleted the lwshang/override_rust_version branch September 21, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwshang @ericswanson-dfinity