Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cycles_burn #434

Merged
merged 7 commits into from
Oct 11, 2023
Merged

feat: cycles_burn #434

merged 7 commits into from
Oct 11, 2023

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Oct 11, 2023 •
edited
Loading

SDK-1280

Description

Include new cycles_burn128() API method in ic0 crate.
Provide a safe wrapper cycles_burn in ic_cdk::api module.
candid_extractor is also updated.

How Has This Been Tested?

e2e with ic-state-machine-test

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review October 11, 2023 20:01
@lwshang lwshang requested a review from a team as a code owner October 11, 2023 20:01
@lwshang lwshang changed the title feat: cycles_burn and feat: cycles_burn Oct 11, 2023
@lwshang lwshang merged commit 2f8b47b into main Oct 11, 2023
16 checks passed
@lwshang lwshang deleted the lwshang/cycles_burn128 branch October 11, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamspofford-dfinity adamspofford-dfinity adamspofford-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwshang @adamspofford-dfinity