Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding icrc1_memo field to the Transaction #445

Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat: Adding icrc1_memo field to the Transaction #445

merged 1 commit into from
Nov 9, 2023

Conversation

maciejdfinity
Copy link
Contributor

@maciejdfinity maciejdfinity commented Nov 9, 2023 •
edited by roman-kashitsyn
Loading

Description

Adding the icrc1_memo field to the Transaction struct. The field was previously added to the Transaction struct in the ICP ledger.

Closes #444.

@maciejdfinity maciejdfinity requested a review from a team as a code owner November 9, 2023 11:01
@maciejdfinity maciejdfinity changed the title feat(icp_ledger): Adding icrc1_memo field to the Transaction feat: Adding icrc1_memo field to the Transaction Nov 9, 2023
@maciejdfinity maciejdfinity enabled auto-merge (squash) November 9, 2023 12:17
@maciejdfinity maciejdfinity merged commit 0b14fac into main Nov 9, 2023
15 of 16 checks passed
@maciejdfinity maciejdfinity deleted the maciej-icrc1memo branch November 9, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sesi200 sesi200 sesi200 approved these changes

@roman-kashitsyn roman-kashitsyn roman-kashitsyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ic-ledger-types no icrc1_memo field in Transaction struct
3 participants
@maciejdfinity @roman-kashitsyn @sesi200