Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query stats: make members public #453

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

Dfinity-skaestle
Copy link
Contributor

It seems we forgot to make the members public when adding query stats to the cdk.

In order for the struct to be useful in canister code, those have to be pub.

@Dfinity-skaestle Dfinity-skaestle requested a review from a team as a code owner January 10, 2024 10:26
@Dfinity-skaestle Dfinity-skaestle changed the title Members need to be pub, otherwise the struct is not usable query stats: make members public Jan 10, 2024
@Dfinity-skaestle Dfinity-skaestle changed the title query stats: make members public fix: query stats: make members public Jan 10, 2024
@sesi200 sesi200 merged commit c01fc17 into main Jan 11, 2024
16 checks passed
@sesi200 sesi200 deleted the skaestle/query-stats-pub branch January 11, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants