Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: more informative README and call* methods #454

Merged
merged 7 commits into from
Jan 12, 2024
Merged

docs: more informative README and call* methods #454

merged 7 commits into from
Jan 12, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Jan 12, 2024

SDK-738
SDK-1299

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang requested a review from a team as a code owner January 12, 2024 20:45
ericswanson-dfinity
ericswanson-dfinity approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple very minor grammar fixes

src/ic-cdk-macros/README.md Outdated Show resolved Hide resolved
src/ic-cdk/README.md Outdated Show resolved Hide resolved
adamspofford-dfinity
adamspofford-dfinity reviewed Jan 12, 2024
View reviewed changes
README.md Show resolved Hide resolved
src/ic-cdk-macros/README.md Outdated Show resolved Hide resolved
src/ic-cdk/README.md Outdated Show resolved Hide resolved
src/ic-cdk/README.md Outdated Show resolved Hide resolved
src/ic-cdk/README.md Outdated Show resolved Hide resolved
src/ic-cdk/src/api/call.rs Outdated Show resolved Hide resolved
src/ic-cdk/src/api/call.rs Outdated Show resolved Hide resolved
src/ic-cdk/src/api/call.rs Outdated Show resolved Hide resolved
src/ic-cdk/src/api/call.rs Outdated Show resolved Hide resolved
src/ic-cdk/src/api/call.rs Outdated Show resolved Hide resolved
@lwshang lwshang enabled auto-merge (squash) January 12, 2024 22:12
@lwshang lwshang merged commit edcbe3a into main Jan 12, 2024
16 checks passed
@lwshang lwshang deleted the lwshang/doc_improve branch January 12, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamspofford-dfinity adamspofford-dfinity adamspofford-dfinity left review comments

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwshang @ericswanson-dfinity @adamspofford-dfinity