Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bindgen): look for standardized environment variables #467

Merged
merged 9 commits into from
Feb 27, 2024
Merged

fix(bindgen): look for standardized environment variables #467

merged 9 commits into from
Feb 27, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Feb 27, 2024 •
edited
Loading

Description

  • Resolve CANISTER_CANDID_PATH and CANISTER_ID from standardized environment variables (uppercase canister names).
    • The support for legacy (non-uppercase) env vars is kept.
    • It will be removed in next major release (v0.2).

How Has This Been Tested?

examples/profile checks:

  • canister names containing hyphens
  • dfx v0.13.0 which only provides deprecated format env vars will cause warnings

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review February 27, 2024 18:40
@lwshang lwshang requested a review from a team as a code owner February 27, 2024 18:40
@lwshang lwshang merged commit e630e83 into main Feb 27, 2024
17 of 18 checks passed
@lwshang lwshang deleted the lwshang/bindgen_standardize_env_var branch February 27, 2024 19:01
@lwshang lwshang mentioned this pull request Feb 27, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwshang @ericswanson-dfinity