Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release ic-cdk v0.13.1 and ic-cdk-macros v0.9.0 #470

Merged
merged 2 commits into from
Mar 1, 2024
Merged

chore: release ic-cdk v0.13.1 and ic-cdk-macros v0.9.0 #470

merged 2 commits into from
Mar 1, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Mar 1, 2024 •
edited
Loading

Description

ic-cdk-macros should have been bumped to 0.9.0 when released as 0.8.5.

It caused the projects using ic-cdk v0.12 and ic-cdk-macros v0.8 broken. Because, ic-cdk-macros v0.8.5 actually generated code for ic-cdk v0.13.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review March 1, 2024 19:33
@lwshang lwshang requested a review from a team as a code owner March 1, 2024 19:33
@lwshang lwshang enabled auto-merge (squash) March 1, 2024 19:45
@lwshang lwshang merged commit ad36d90 into main Mar 1, 2024
16 checks passed
@lwshang lwshang deleted the lwshang/release_0.13.1 branch March 1, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity Awaiting requested review from ericswanson-dfinity

@chenyan-dfinity chenyan-dfinity Awaiting requested review from chenyan-dfinity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwshang @ericswanson-dfinity